-
Notifications
You must be signed in to change notification settings - Fork 698
Commerce Build 3.9.8 #1706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: felix/3.9.7
Are you sure you want to change the base?
Commerce Build 3.9.8 #1706
Conversation
eric-ships
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How were these changes tested?
| export { CoinbaseWalletProvider } from './provider/CoinbaseWalletProvider'; | ||
| export default CoinbaseWalletSDK; | ||
|
|
||
| export { setCommerceCorrelationId } from './telemetry/commerceCorrelationId'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this being used here?
eric-ships
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding unit tests?
|
Noticed typecheck and tests are failing, can we fix before adding to the paymentlink app? |
spencerstock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Perhaps we should pause on this. It appears half of the test are failing! Jeez. |
Summary
🚀 Release v3.9.8 - Commerce Correlation ID and Mobile Relay Enhancements
This release introduces commerce correlation ID tracking and mobile relay improvements to enhance analytics and user experience for Payment Link integrations.
📋 Changes Summary
🔧 Core Features:
📦 Version Bump:
3.9.7→3.9.8🛠 Technical Changes
New Commerce Correlation ID Module
src/telemetry/commerceCorrelationId.tssetCommerceCorrelationId()andgetCommerceCorrelationId()functionssetCommerceCorrelationIdfrom main SDK index for public APIEnhanced QR Code URL Generation
src/core/util.tsisMobileRelayparameter tocreateQrUrl()functionpl: 't'- Payment Link custom build flagm: 't'- Mobile relay flag (when applicable)cid: <correlationId>- Commerce correlation ID (when available)Provider Request Tracking
src/provider/CoinbaseWalletProvider.tslogRequestStarted,logRequestCompleted,logRequestError) with commerce correlation ID trackingMobile Relay Improvements
src/relay/mobile/MobileRelay.tslogMobileWalletLinkRequestAccountsDeeplinkedtelemetry eventTelemetry Events Updates
src/telemetry/events/provider.ts,src/telemetry/events/walletlink.tscommerceCorrelationIdparameter to all provider request eventsArchitecture Improvements
src/relay/walletlink/WalletLinkRelay.ts🎯 Use Cases
This release specifically targets:
✅ Testing Considerations
🔗 Files Changed
packages/wallet-sdk/package.json- Version bumppackages/wallet-sdk/src/version.ts- Version constant updatepackages/wallet-sdk/src/index.ts- Export new public APIpackages/wallet-sdk/src/core/util.ts- QR URL enhancementspackages/wallet-sdk/src/provider/CoinbaseWalletProvider.ts- Request trackingpackages/wallet-sdk/src/relay/mobile/MobileRelay.ts- Mobile improvementspackages/wallet-sdk/src/relay/walletlink/WalletLinkRelay.ts- Architecture updatespackages/wallet-sdk/src/telemetry/commerceCorrelationId.ts- New filepackages/wallet-sdk/src/telemetry/events/provider.ts- Enhanced eventspackages/wallet-sdk/src/telemetry/events/walletlink.ts- New mobile eventHow did you test your changes?